Messages in this thread | | | Date | Fri, 4 Sep 2020 17:21:54 +1000 | From | Herbert Xu <> | Subject | Re: [PATCH] cypto: mediatek - fix leaks in mtk_desc_ring_alloc |
| |
Xiaoliang Pang <dawning.pang@gmail.com> wrote: > In the init loop, if an error occurs in function 'dma_alloc_coherent', > then goto the err_cleanup section, > in the cleanup loop, after run i--, > the struct mtk_ring rising[i] will not be released, > causing a memory leak > > Signed-off-by: Xiaoliang Pang <dawning.pang@gmail.com> > --- > drivers/crypto/mediatek/mtk-platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/mediatek/mtk-platform.c b/drivers/crypto/mediatek/mtk-platform.c > index 7e3ad085b5bd..05d341e4a696 100644 > --- a/drivers/crypto/mediatek/mtk-platform.c > +++ b/drivers/crypto/mediatek/mtk-platform.c > @@ -469,7 +469,7 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp) > return 0; > > err_cleanup: > - for (; i--; ) { > + for (; i >= 0; --i) {
How about a do while loop instead?
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |