Messages in this thread |  | | Date | Tue, 29 Sep 2020 22:49:01 -0700 | From | Nicolin Chen <> | Subject | Re: [PATCH v2 2/3] iommu/tegra-smmu: Rework .probe_device and .attach_dev |
| |
On Wed, Sep 30, 2020 at 08:11:52AM +0300, Dmitry Osipenko wrote: > 30.09.2020 03:30, Nicolin Chen пишет: > > + /* An invalid mc pointer means mc and smmu drivers are not ready */ > > + if (IS_ERR_OR_NULL(mc)) > > tegra_get_memory_controller() doesn't return NULL.
Well, I don't want to assume that it'd do that forever, and the NULL check of IS_ERR_OR_NULL is marked "unlikely" so it doesn't hurt to have.
|  |