lkml.org 
[lkml]   [2020]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/30] spi: dw: Use ternary op to init set_cs callback
    On Wed, Sep 30, 2020 at 04:01:17PM +0100, Mark Brown wrote:
    > On Wed, Sep 30, 2020 at 05:57:59PM +0300, Serge Semin wrote:
    > > On Wed, Sep 30, 2020 at 12:55:55AM +0300, Serge Semin wrote:
    >
    > > > + if (dws->set_cs)
    > > > + master->set_cs = dws->set_cs;
    > > > + else
    > > > + master->set_cs = dw_spi_set_cs;
    >

    > > Judging by having your comment on this patch you obviously didn't like the
    > > ternary operator used to assign a default value to the set_cs callback. So I
    > > suggested a solution, which may suit you. What do you think about it? Agree,
    > > disagree, insist on leaving this part of the code along, etc.
    >
    > That looks fine.

    Ok. I'll implement it in the next patchset version.

    -Sergey

    \
     
     \ /
      Last update: 2020-09-30 17:08    [W:4.145 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site