lkml.org 
[lkml]   [2020]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 12/12] mm/filemap: Return only head pages from find_get_entries
On Wed, Sep 30, 2020 at 02:15:12PM +0200, Jan Kara wrote:
> On Mon 14-09-20 14:00:42, Matthew Wilcox (Oracle) wrote:
> > All callers now expect head (and base) pages, and can handle multiple
> > head pages in a single batch, so make find_get_entries() behave that way.
> > Also take the opportunity to make it use the pagevec infrastructure
> > instead of open-coding how pvecs behave. This has the side-effect of
> > being able to append to a pagevec with existing contents, although we
> > don't make use of that functionality anywhere yet.
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>
> Looks good to me. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> I'm just curious: What has happened to pagevec_lookup_entries() call in
> invalidate_inode_pages2_range()? Your series appears to be based on a tree
> where the call already does not exist...

That went away in patch 10 of this series.

\
 
 \ /
  Last update: 2020-09-30 14:37    [W:0.078 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site