lkml.org 
[lkml]   [2020]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH next v2 1/2] printk: avoid and/or handle record truncation
Date
On 2020-09-30, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> On (20/09/30 11:07), John Ogness wrote:
>> bool prb_reserve_in_last(struct prb_reserved_entry *e, struct printk_ringbuffer *rb,
>> - struct printk_record *r, u32 caller_id);
>> + struct printk_record *r, u32 caller_id, unsigned int max_size);
>
> Isn't `max_size' always LOG_LINE_MAX?

Yes. But I still think it makes sense that it is an argument of the
function. It is quite an important setting and hard-coding it within the
ringbuffer code might lead to hidden problems later.

John Ogness

\
 
 \ /
  Last update: 2020-09-30 12:25    [W:0.075 / U:47.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site