lkml.org 
[lkml]   [2020]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 09/29] arm64: disable recordmcount with DYNAMIC_FTRACE_WITH_REGS
    Hi Sami,

    On Tue, Sep 29, 2020 at 02:46:11PM -0700, Sami Tolvanen wrote:
    > Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to disable
    > recordmcount when DYNAMIC_FTRACE_WITH_REGS is selected.

    Could you please add an explanation as to /why/ this is necessary in the
    commit message? I couldn't figure this out form the commit message
    alone, and reading the cover letter also didn't help.

    If the minimum required GCC version supports patchable-function-entry
    I'd be happy to make that a requirement for dynamic ftrace on arm64, as
    then we'd only need to support one mechanism, and can get rid of some
    redundant code. We already default to it when present anyhow.

    >
    > Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
    > ---
    > arch/arm64/Kconfig | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
    > index 6d232837cbee..ad522b021f35 100644
    > --- a/arch/arm64/Kconfig
    > +++ b/arch/arm64/Kconfig
    > @@ -155,6 +155,8 @@ config ARM64
    > select HAVE_DYNAMIC_FTRACE
    > select HAVE_DYNAMIC_FTRACE_WITH_REGS \
    > if $(cc-option,-fpatchable-function-entry=2)
    > + select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY \
    > + if DYNAMIC_FTRACE_WITH_REGS

    This doesn't look quite right to me. Presumably we shouldn't allow
    DYNAMIC_FTRACE_WITH_REGS to be selected if HAVE_DYNAMIC_FTRACE_WITH_REGS
    isn't.

    Thanks,
    Mark.

    \
     
     \ /
      Last update: 2020-09-30 12:00    [W:4.128 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site