Messages in this thread | | | Date | Wed, 30 Sep 2020 13:33:19 +0530 | From | Pratyush Yadav <> | Subject | Re: [PATCH v13 13/15] mtd: spi-nor: core: expose spi_nor_default_setup() in core.h |
| |
On 30/09/20 07:51AM, Tudor.Ambarus@microchip.com wrote: > On 9/16/20 3:44 PM, Pratyush Yadav wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > Flashes might want to add a custom setup hook to configure the flash in > > the proper mode for operation. But after that, they would still want to > > run the default setup hook because it selects the read, program, and > > erase operations. Since there is little point in repeating all that > > code, expose the spi_nor_default_setup() in core.h to > > manufacturer-specific files. > > But you don't use it in the following patches. Can we drop this one for now?
I used it for earlier versions but not for the latest ones. This can be dropped for now.
> > > > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> > > --- > > drivers/mtd/spi-nor/core.c | 4 ++-- > > drivers/mtd/spi-nor/core.h | 3 +++ > > 2 files changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > > index d5c92c9c7307..34edfcf33172 100644 > > --- a/drivers/mtd/spi-nor/core.c > > +++ b/drivers/mtd/spi-nor/core.c > > @@ -2759,8 +2759,8 @@ static int spi_nor_select_erase(struct spi_nor *nor) > > return 0; > > } > > > > -static int spi_nor_default_setup(struct spi_nor *nor, > > - const struct spi_nor_hwcaps *hwcaps) > > +int spi_nor_default_setup(struct spi_nor *nor, > > + const struct spi_nor_hwcaps *hwcaps) > > { > > struct spi_nor_flash_parameter *params = nor->params; > > u32 ignored_mask, shared_mask; > > diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h > > index e2c7324d997e..10dc03506f93 100644 > > --- a/drivers/mtd/spi-nor/core.h > > +++ b/drivers/mtd/spi-nor/core.h > > @@ -453,6 +453,9 @@ int spi_nor_post_bfpt_fixups(struct spi_nor *nor, > > const struct sfdp_bfpt *bfpt, > > struct spi_nor_flash_parameter *params); > > > > +int spi_nor_default_setup(struct spi_nor *nor, > > + const struct spi_nor_hwcaps *hwcaps); > > + > > static struct spi_nor __maybe_unused *mtd_to_spi_nor(struct mtd_info *mtd) > > { > > return mtd->priv; > > -- > > 2.28.0 > > >
-- Regards, Pratyush Yadav Texas Instruments India
| |