Messages in this thread | | | Date | Wed, 30 Sep 2020 09:47:28 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH v2 4/4] iio: adc: at91_adc: remove of_match_ptr() usage |
| |
Hi,
On 30/09/2020 09:00:08+0300, Alexandru Ardelean wrote: > Since the driver should be allowed to build without OF support, the > of_match_ptr() is redundant. >
This can probably be squashed with the previous commit.
Also, I think that you should really make the driver DT only else, the driver will carry dead code and there will be no reminder that a cleanup is needed.
I can take care of that if you feel that this is more work than what you wanted to spend on this driver.
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > --- > drivers/iio/adc/at91_adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 7d846a2852a5..473bffe84fbd 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -1466,7 +1466,7 @@ static struct platform_driver at91_adc_driver = { > .id_table = at91_adc_ids, > .driver = { > .name = DRIVER_NAME, > - .of_match_table = of_match_ptr(at91_adc_dt_ids), > + .of_match_table = at91_adc_dt_ids, > .pm = &at91_adc_pm_ops, > }, > }; > -- > 2.17.1 >
-- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |