lkml.org 
[lkml]   [2020]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC V2] mm/vmstat: Add events for HugeTLB migration
On Wed, Sep 30, 2020 at 11:30:49AM +0530, Anshuman Khandual wrote:
> - is_thp = PageTransHuge(page) && !PageHuge(page);
> - nr_subpages = thp_nr_pages(page);
> + is_thp = false;
> + is_hugetlb = false;
> + if (PageTransHuge(page)) {
> + if (PageHuge(page))
> + is_hugetlb = true;
> + else
> + is_thp = true;
> + }

Since PageHuge only returns true for hugetlb pages, I think the following is
more simple?

if (PageHuge(page))
is_hugetlb = true;
else if (PageTransHuge(page))
is_thp = true


Besides that, it looks good to me:

Reviewed-by: Oscar Salvador <osalvador@suse.de>

--
Oscar Salvador
SUSE L3

\
 
 \ /
  Last update: 2020-09-30 09:47    [W:0.092 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site