lkml.org 
[lkml]   [2020]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v13 12/15] mtd: spi-nor: core: disable Octal DTR mode on suspend.
On 30/09/20 07:40AM, Tudor.Ambarus@microchip.com wrote:
> On 9/16/20 3:44 PM, Pratyush Yadav wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > On resume, the init procedure will be run that will re-enable it.
> >
> > Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
>
> > ---
> > drivers/mtd/spi-nor/core.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> > index 853dfa02f0de..d5c92c9c7307 100644
> > --- a/drivers/mtd/spi-nor/core.c
> > +++ b/drivers/mtd/spi-nor/core.c
> > @@ -3212,6 +3212,23 @@ static void spi_nor_soft_reset(struct spi_nor *nor)
> > usleep_range(SPI_NOR_SRST_SLEEP_MIN, SPI_NOR_SRST_SLEEP_MAX);
> > }
> >
> > +/* mtd suspend handler */
> > +static int spi_nor_suspend(struct mtd_info *mtd)
> > +{
> > + struct spi_nor *nor = mtd_to_spi_nor(mtd);
> > + struct device *dev = nor->dev;
> > + int ret;
> > +
> > + /* Disable octal DTR mode if we enabled it. */
> > + ret = spi_nor_octal_dtr_enable(nor, false);
> > + if (ret) {
> > + dev_err(dev, "suspend() failed\n");
>
> we can get rid of dev local variable as it is used only once. you can use
> nor->dev directly

Ok.

> > + return ret;
> > + }
>
> and maybe just return ret; directly. spi_nor_octal_dtr_enable() returns 0 on
> success.

Ok.

> Looks good.
>

--
Regards,
Pratyush Yadav
Texas Instruments India

\
 
 \ /
  Last update: 2020-09-30 09:46    [W:0.057 / U:8.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site