lkml.org 
[lkml]   [2020]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"
From
Date
Quoting David Collins (2020-09-22 15:04:18)
> Change the format of spmi bus device names from:
> <spmi_bus_number>-<spmi_device_sid>
> Example: 0-01
> to this:
> spmi<spmi_bus_number>-<spmi_device_sid>
> Example: spmi0-01
>
> This helps to disambiguate SPMI device regmaps from I2C ones
> at /sys/kernel/debug/regmap since I2C devices use a very
> similar naming scheme: 0-0000.

Can regmap debugfs prepend the bus name on the node made in debugfs?
Does it do that already?

>
> Signed-off-by: David Collins <collinsd@codeaurora.org>
> ---
> drivers/spmi/spmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
> index c16b60f..ec94439 100644
> --- a/drivers/spmi/spmi.c
> +++ b/drivers/spmi/spmi.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * Copyright (c) 2012-2015, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2012-2015, 2020, The Linux Foundation. All rights reserved.
> */
> #include <linux/kernel.h>
> #include <linux/errno.h>
> @@ -62,7 +62,7 @@ int spmi_device_add(struct spmi_device *sdev)
> struct spmi_controller *ctrl = sdev->ctrl;
> int err;
>
> - dev_set_name(&sdev->dev, "%d-%02x", ctrl->nr, sdev->usid);
> + dev_set_name(&sdev->dev, "spmi%d-%02x", ctrl->nr, sdev->usid);
>
> err = device_add(&sdev->dev);
> if (err < 0) {

\
 
 \ /
  Last update: 2020-10-01 02:08    [W:0.068 / U:5.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site