lkml.org 
[lkml]   [2020]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next] net: dsa: Support bridge 802.1Q while untagging
From
Date


On 9/30/2020 1:43 PM, Vladimir Oltean wrote:
> On Wed, Sep 30, 2020 at 01:31:03PM -0700, Florian Fainelli wrote:
>> While we are it, call __vlan_find_dev_deep_rcu() which makes use the
>> VLAN group array which is faster.
>
> Not just "while at it", but I do wonder whether it isn't, in fact,
> called "deep" for a reason:
>
> /*
> * Lower devices of master uppers (bonding, team) do not have
> * grp assigned to themselves. Grp is assigned to upper device
> * instead.
> */
>
> I haven't tested this, but I wonder if you could actually call
> __vlan_find_dev_deep_rcu() on the switch port interface and it would
> cover both this and the bridge having an 8021q upper automatically?

Let me give this a try.
--
Florian

\
 
 \ /
  Last update: 2020-10-01 01:31    [W:0.043 / U:11.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site