Messages in this thread |  | | Date | Wed, 30 Sep 2020 13:03:31 -0700 | From | Nicolin Chen <> | Subject | Re: [PATCH v3 3/3] iommu/tegra-smmu: Add PCI support |
| |
On Wed, Sep 30, 2020 at 05:53:20PM +0300, Dmitry Osipenko wrote: > ... > > +#ifdef CONFIG_PCI > > + if (!iommu_present(&pci_bus_type)) { > > > In the previous reply you said that you're borrowing this check from the > arm-smmu driver, but arm-smmu also has a similar check for > platform_bus_type, while Tegra SMMU driver doesn't have it. Hence I'm > objecting the necessity of having this check. > > Please give a rationale for having this check in the code. And please > note that cargo cult isn't a rationale to me.
Okay, okay....I will remove it upon testing.
|  |