Messages in this thread |  | | Date | Wed, 30 Sep 2020 13:17:24 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno |
| |
On Wed, 02 Sep 2020 16:43:43 +0200, Pali Rohár wrote: > Driver ->power_on and ->power_off callbacks leaks internal SMCC firmware > return codes to phy caller. This patch converts SMCC error codes to > standard linux errno codes. Include file linux/arm-smccc.h already provides > defines for SMCC error codes, so use them instead of custom driver defines. > Note that return value is signed 32bit, but stored in unsigned long type > with zero padding. > > Signed-off-by: Pali Rohár <pali@kernel.org> > --- > drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 14 +++++++++++--- > drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 14 +++++++++++--- > 2 files changed, 22 insertions(+), 6 deletions(-) >
Reviewed-by: Rob Herring <robh@kernel.org>
|  |