lkml.org 
[lkml]   [2020]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 4/4] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication
    Hi Prabhakar,

    On Tue, Aug 25, 2020 at 6:28 PM Lad Prabhakar
    <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
    > Add support for LED trigger on SD2 interface.
    >
    > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

    > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
    > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
    > @@ -63,6 +63,16 @@
    > enable-gpios = <&gpio3 11 GPIO_ACTIVE_HIGH>;
    > };
    >
    > + leds {
    > + compatible = "gpio-leds";
    > +
    > + sdhi2_led {
    > + label = "sdio-led";
    > + gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;

    GPIO_ACTIVE_HIGH?

    The LED is driven by an NPN transistor, with the LED between 3.3V and
    the transistor's collector.

    > + linux,default-trigger = "mmc1";
    > + };
    > + };
    > +
    > lvds-receiver {
    > compatible = "ti,ds90cf384a", "lvds-decoder";
    > vcc-supply = <&vcc_3v3_tft1>;

    With the above fixed:
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2020-09-03 14:27    [W:4.329 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site