lkml.org 
[lkml]   [2020]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/3] remoteproc: Expose remoteproc configuration through sysfs
On Thu 03 Sep 18:03 CDT 2020, Rishabh Bhatnagar wrote:

> Add a feature flag to expose some of the remoteproc configuration
> through sysfs. This feature is helpful in systems where debugfs is
> not available/mounted. Currently the recovery and coredump
> configuration is exposed through sysfs rather than debugfs when
> this feature is selected.
>

This commit message gives me the feeling that it's about making a
selection between debugfs vs sysfs. But the patches moves the code from
debugfs to sysfs and then hide it behind this config option.

That said, I just commented on v2 questioning that this should be a
compile time option at all - might be useful for some drivers to
dynamically "hide" these sysfs attributes though.

Regards,
Bjorn

> Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
> ---
> drivers/remoteproc/Kconfig | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index c6659dfe..98d52cbe 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -275,6 +275,17 @@ config TI_K3_DSP_REMOTEPROC
> It's safe to say N here if you're not interested in utilizing
> the DSP slave processors.
>
> +config RPROC_SYSFS_CONFIGURATION_SUPPORT
> + bool "Expose remoteproc configuration sysfs entries"
> + default y
> + help
> + Say y here to expose recovery and coredump configuration sysfs
> + entries. This is helpful in operating systems where debugfs is
> + not available/mounted.
> +
> + It's safe to say N here if you are not interested in accessing
> + recovery and coredump configuration through sysfs.
> +
> endif # REMOTEPROC
>
> endmenu
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>

\
 
 \ /
  Last update: 2020-09-04 02:05    [W:0.208 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site