Messages in this thread | | | Subject | Re: [PATCH 1/4] drivers: hv: dxgkrnl: core code | From | Iouri Tarassov <> | Date | Thu, 3 Sep 2020 14:39:05 -0700 |
| |
Hi Greg,
On 8/27/2020 11:18 PM, Greg KH wrote: > On Thu, Aug 27, 2020 at 05:25:23PM -0700, Iouri Tarassov wrote: > > > > +bool dxghwqueue_acquire_reference(struct dxghwqueue *hwqueue) > > > > +{ > > > > + return refcount_inc_not_zero(&hwqueue->refcount); > > > > +} > > > > > > Midlayers are evil. > > I strongly agree in general, but think that in our case the layers are very > > small. It allows to quickly find all places where a reference/dereference on > > an object is done and addition of debug tracing to catch errors. > > Again, no, please remove all layers like this. They just make it > impossible for others to review and understand the code over time. > > Also, in this specific case, it would have allowed me to easily realize > that you are doing this type of call incorrectly and should be using a > different data structure :)
Are you suggesting that the current code is incorrect? Could you comment what changes need to be done?
Thanks Iouri
| |