lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 382/388] s390/zcrypt: Fix ZCRYPT_PERDEV_REQCNT ioctl
    Date
    From: Christian Borntraeger <borntraeger@de.ibm.com>

    commit f7e80983f0cf470bb82036e73bff4d5a7daf8fc2 upstream.

    reqcnt is an u32 pointer but we do copy sizeof(reqcnt) which is the
    size of the pointer. This means we only copy 8 byte. Let us copy
    the full monty.

    Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
    Cc: Harald Freudenberger <freude@linux.ibm.com>
    Cc: stable@vger.kernel.org
    Fixes: af4a72276d49 ("s390/zcrypt: Support up to 256 crypto adapters.")
    Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
    Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/s390/crypto/zcrypt_api.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/s390/crypto/zcrypt_api.c
    +++ b/drivers/s390/crypto/zcrypt_api.c
    @@ -1419,7 +1419,8 @@ static long zcrypt_unlocked_ioctl(struct
    if (!reqcnt)
    return -ENOMEM;
    zcrypt_perdev_reqcnt(reqcnt, AP_DEVICES);
    - if (copy_to_user((int __user *) arg, reqcnt, sizeof(reqcnt)))
    + if (copy_to_user((int __user *) arg, reqcnt,
    + sizeof(u32) * AP_DEVICES))
    rc = -EFAULT;
    kfree(reqcnt);
    return rc;

    \
     
     \ /
      Last update: 2020-09-29 13:47    [W:2.897 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site