lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 320/388] net: openvswitch: use div_u64() for 64-by-32 divisions
    Date
    From: Tonghao Zhang <xiangxia.m.yue@gmail.com>

    [ Upstream commit 659d4587fe7233bfdff303744b20d6f41ad04362 ]

    Compile the kernel for arm 32 platform, the build warning found.
    To fix that, should use div_u64() for divisions.
    | net/openvswitch/meter.c:396: undefined reference to `__udivdi3'

    [add more commit msg, change reported tag, and use div_u64 instead
    of do_div by Tonghao]

    Fixes: e57358873bb5d6ca ("net: openvswitch: use u64 for meter bucket")
    Reported-by: kbuild test robot <lkp@intel.com>
    Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
    Tested-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/openvswitch/meter.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/openvswitch/meter.c b/net/openvswitch/meter.c
    index b10734f18bbd6..541eea74ef7a6 100644
    --- a/net/openvswitch/meter.c
    +++ b/net/openvswitch/meter.c
    @@ -252,7 +252,7 @@ static struct dp_meter *dp_meter_create(struct nlattr **a)
    * Start with a full bucket.
    */
    band->bucket = (band->burst_size + band->rate) * 1000ULL;
    - band_max_delta_t = band->bucket / band->rate;
    + band_max_delta_t = div_u64(band->bucket, band->rate);
    if (band_max_delta_t > meter->max_delta_t)
    meter->max_delta_t = band_max_delta_t;
    band++;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-29 13:44    [W:3.647 / U:2.908 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site