lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 091/121] btrfs: dont force read-only after error in drop snapshot
    Date
    From: David Sterba <dsterba@suse.com>

    [ Upstream commit 7c09c03091ac562ddca2b393e5d65c1d37da79f1 ]

    Deleting a subvolume on a full filesystem leads to ENOSPC followed by a
    forced read-only. This is not a transaction abort and the filesystem is
    otherwise ok, so the error should be just propagated to the callers.

    This is caused by unnecessary call to btrfs_handle_fs_error for all
    errors, except EAGAIN. This does not make sense as the standard
    transaction abort mechanism is in btrfs_drop_snapshot so all relevant
    failures are handled.

    Originally in commit cb1b69f4508a ("Btrfs: forced readonly when
    btrfs_drop_snapshot() fails") there was no return value at all, so the
    btrfs_std_error made some sense but once the error handling and
    propagation has been implemented we don't need it anymore.

    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/btrfs/extent-tree.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
    index c0033a0d00787..b5bff1e760a34 100644
    --- a/fs/btrfs/extent-tree.c
    +++ b/fs/btrfs/extent-tree.c
    @@ -9435,8 +9435,6 @@ out:
    */
    if (!for_reloc && root_dropped == false)
    btrfs_add_dead_root(root);
    - if (err && err != -EAGAIN)
    - btrfs_handle_fs_error(fs_info, err, NULL);
    return err;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-29 13:13    [W:2.401 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site