lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] arm64: dts: zynqmp: Fix leds subnode name for zcu100/ultra96 v1
po 24. 8. 2020 v 12:28 odesílatel Michal Simek <michal.simek@xilinx.com> napsal:
>
> Fix the leds subnode names to match (^led-[0-9a-f]$|led).
>
> Similar change has been also done by commit 08dc0e5dd9aa ("arm64: dts:
> meson: fix leds subnodes name").
>
> The patch is fixing this warning:
> avnet-ultra96-rev1.dt.yaml: leds: 'ds2', 'ds3', 'ds4', 'ds5' do not match
> any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> vbus-det led is not fixed because it is not LED. It should be likely
> handled as gpio hog.
> ---
> arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index d60110ad8367..2352dc553ba7 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -56,27 +56,27 @@ sw4 {
>
> leds {
> compatible = "gpio-leds";
> - ds2 {
> + led-ds2 {
> label = "ds2";
> gpios = <&gpio 20 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "heartbeat";
> };
>
> - ds3 {
> + led-ds3 {
> label = "ds3";
> gpios = <&gpio 19 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "phy0tx"; /* WLAN tx */
> default-state = "off";
> };
>
> - ds4 {
> + led-ds4 {
> label = "ds4";
> gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "phy0rx"; /* WLAN rx */
> default-state = "off";
> };
>
> - ds5 {
> + led-ds5 {
> label = "ds5";
> gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "bluetooth-power";
> --
> 2.28.0
>

Applied.
M


--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs

\
 
 \ /
  Last update: 2020-09-29 13:02    [W:0.077 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site