lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] dt-bindings: mfd: correct interrupt flags in examples
On Tue, Sep 29, 2020 at 10:46:57AM +0100, Lee Jones wrote:
> On Thu, 17 Sep 2020, Krzysztof Kozlowski wrote:
>
> > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> > These are simple defines so they could be used in DTS but they will not
> > have the same meaning:
> > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
> >
> > Correct the interrupt flags, assuming the author of the code wanted same
> > logical behavior behind the name "ACTIVE_xxx", this is:
> > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> # for BD70528
> > Acked-by: Tim Harvey <tharvey@gateworks.com> # for gateworks-gsc.yaml
> > Acked-by: Rob Herring <robh@kernel.org>
> >
> > ---
> >
> > Changes since v1:
> > 1. Add acks
>
> FYI, this should not bump the patch version.

Yes, that was my mistake. I kept this one with multiple other similar
patches and was updating all of them.... but I sent each group
independently at the end so this one did not receive any updates
actually.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2020-09-29 11:55    [W:0.059 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site