lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 08/12] mm: Remove nr_entries parameter from pagevec_lookup_entries
On Mon 14-09-20 14:00:38, Matthew Wilcox (Oracle) wrote:
> All callers want to fetch the full size of the pvec.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

Honza

> ---
> include/linux/pagevec.h | 2 +-
> mm/swap.c | 4 ++--
> mm/truncate.c | 5 ++---
> 3 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/pagevec.h b/include/linux/pagevec.h
> index 4b245592262c..ce77724a2ab7 100644
> --- a/include/linux/pagevec.h
> +++ b/include/linux/pagevec.h
> @@ -27,7 +27,7 @@ void __pagevec_release(struct pagevec *pvec);
> void __pagevec_lru_add(struct pagevec *pvec);
> unsigned pagevec_lookup_entries(struct pagevec *pvec,
> struct address_space *mapping, pgoff_t start, pgoff_t end,
> - unsigned nr_entries, pgoff_t *indices);
> + pgoff_t *indices);
> void pagevec_remove_exceptionals(struct pagevec *pvec);
> unsigned pagevec_lookup_range(struct pagevec *pvec,
> struct address_space *mapping,
> diff --git a/mm/swap.c b/mm/swap.c
> index b6e56a84b466..d4e3ba4c967c 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -1058,9 +1058,9 @@ void __pagevec_lru_add(struct pagevec *pvec)
> */
> unsigned pagevec_lookup_entries(struct pagevec *pvec,
> struct address_space *mapping, pgoff_t start, pgoff_t end,
> - unsigned nr_entries, pgoff_t *indices)
> + pgoff_t *indices)
> {
> - pvec->nr = find_get_entries(mapping, start, end, nr_entries,
> + pvec->nr = find_get_entries(mapping, start, end, PAGEVEC_SIZE,
> pvec->pages, indices);
> return pagevec_count(pvec);
> }
> diff --git a/mm/truncate.c b/mm/truncate.c
> index 69ea72e7fc1c..bbd0a02eaed7 100644
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -377,7 +377,7 @@ void truncate_inode_pages_range(struct address_space *mapping,
> for ( ; ; ) {
> cond_resched();
> if (!pagevec_lookup_entries(&pvec, mapping, index, end - 1,
> - PAGEVEC_SIZE, indices)) {
> + indices)) {
> /* If all gone from start onwards, we're done */
> if (index == start)
> break;
> @@ -611,8 +611,7 @@ int invalidate_inode_pages2_range(struct address_space *mapping,
>
> pagevec_init(&pvec);
> index = start;
> - while (pagevec_lookup_entries(&pvec, mapping, index, end,
> - PAGEVEC_SIZE, indices)) {
> + while (pagevec_lookup_entries(&pvec, mapping, index, end, indices)) {
> for (i = 0; i < pagevec_count(&pvec); i++) {
> struct page *page = pvec.pages[i];
>
> --
> 2.28.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR

\
 
 \ /
  Last update: 2020-09-29 11:05    [W:0.257 / U:1.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site