lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 023/388] leds: mlxreg: Fix possible buffer overflow
    Date
    From: Oleh Kravchenko <oleg@kaa.org.ua>

    [ Upstream commit 7c6082b903ac28dc3f383fba57c6f9e7e2594178 ]

    Error was detected by PVS-Studio:
    V512 A call of the 'sprintf' function will lead to overflow of
    the buffer 'led_data->led_cdev_name'.

    Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
    Acked-by: Pavel Machek <pavel@ucw.cz>
    Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua>
    Signed-off-by: Pavel Machek <pavel@ucw.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/leds/leds-mlxreg.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/leds/leds-mlxreg.c b/drivers/leds/leds-mlxreg.c
    index cabe379071a7c..82aea1cd0c125 100644
    --- a/drivers/leds/leds-mlxreg.c
    +++ b/drivers/leds/leds-mlxreg.c
    @@ -228,8 +228,8 @@ static int mlxreg_led_config(struct mlxreg_led_priv_data *priv)
    brightness = LED_OFF;
    led_data->base_color = MLXREG_LED_GREEN_SOLID;
    }
    - sprintf(led_data->led_cdev_name, "%s:%s", "mlxreg",
    - data->label);
    + snprintf(led_data->led_cdev_name, sizeof(led_data->led_cdev_name),
    + "mlxreg:%s", data->label);
    led_cdev->name = led_data->led_cdev_name;
    led_cdev->brightness = brightness;
    led_cdev->max_brightness = LED_ON;
    --
    2.25.1


    \
     
     \ /
      Last update: 2022-09-17 16:09    [W:3.277 / U:1.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site