lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 1/2] dt-bindings: usb: Add binding for discrete onboard USB hubs
    On Mon, Sep 28, 2020 at 10:13:54AM -0700, Matthias Kaehlcke wrote:
    > Discrete onboard USB hubs (an example for such a hub is the Realtek
    > RTS5411) need to be powered and may require initialization of other
    > resources (like GPIOs or clocks) to work properly. This adds a device
    > tree binding for these hubs.
    >
    > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
    > ---
    >
    > (no changes since v3)
    >
    > Changes in v3:
    > - updated commit message
    > - removed recursive reference to $self
    > - adjusted 'compatible' definition to support multiple entries
    > - changed USB controller phandle to be a node
    >
    > Changes in v2:
    > - removed 'wakeup-source' and 'power-off-in-suspend' properties
    > - consistently use spaces for indentation in example
    >
    > .../bindings/usb/onboard_usb_hub.yaml | 54 +++++++++++++++++++
    > 1 file changed, 54 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml b/Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml
    > new file mode 100644
    > index 000000000000..c9783da3e75c
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml
    > @@ -0,0 +1,54 @@
    > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/usb/onboard_usb_hub.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Binding for onboard USB hubs
    > +
    > +maintainers:
    > + - Matthias Kaehlcke <mka@chromium.org>
    > +
    > +properties:
    > + compatible:
    > + items:
    > + - enum:
    > + - realtek,rts5411
    > + - const: onboard-usb-hub
    > +
    > + vdd-supply:
    > + description:
    > + phandle to the regulator that provides power to the hub.
    > +
    > +required:
    > + - compatible
    > + - vdd-supply
    > +
    > +examples:
    > + - |
    > + usb_hub: usb-hub {
    > + compatible = "realtek,rts5411", "onboard-usb-hub";
    > + vdd-supply = <&pp3300_hub>;
    > + };

    As I said in prior version, this separate node and 'hub' phandle is not
    going to work. You are doing this because you want a platform driver for
    "realtek,rts5411". That may be convenient for Linux, but doesn't reflect
    the h/w.

    Rob

    \
     
     \ /
      Last update: 2020-09-29 22:17    [W:3.068 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site