Messages in this thread | | | Date | Tue, 29 Sep 2020 19:36:50 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH v2 02/12] mm/shmem: Use pagevec_lookup in shmem_unlock_mapping |
| |
On Tue, Sep 29, 2020 at 10:28:28AM +0200, Jan Kara wrote: > On Mon 14-09-20 14:00:32, Matthew Wilcox (Oracle) wrote: > > The comment shows that the reason for using find_get_entries() is now > > stale; find_get_pages() will not return 0 if it hits a consecutive run > > of swap entries, and I don't believe it has since 2011. pagevec_lookup() > > is a simpler function to use than find_get_pages(), so use it instead. > > > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > > Looks good to me. BTW, I think I've already reviewed this... You can add: > > Reviewed-by: Jan Kara <jack@suse.cz>
So you did! My apologies for missing that.
| |