| Date | Tue, 29 Sep 2020 20:01:23 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 02/17] x86/acrn: Introduce acrn_{setup, remove}_intr_handler() |
| |
On Tue, Sep 22, 2020 at 07:42:56PM +0800, shuo.a.liu@intel.com wrote: > +void acrn_setup_intr_handler(void (*handler)(void)) > +{ > + acrn_intr_handler = handler; > +} > +EXPORT_SYMBOL_GPL(acrn_setup_intr_handler); > + > +void acrn_remove_intr_handler(void) > +{ > + acrn_intr_handler = NULL; > +} > +EXPORT_SYMBOL_GPL(acrn_remove_intr_handler);
I don't like this one bit.
Also, what stops the module from doing acrn_remove_intr_handler() while it gets a HYPERVISOR_CALLBACK_VECTOR interrupt and the handler disappearing from under it?
IOW, this should be an atomic notifier instead.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
|