Messages in this thread | | | Date | Tue, 29 Sep 2020 09:42:27 -0700 | From | Joe Perches <> | Subject | Re: [PATCH 10/20] media: lmedm04: use semicolons rather than commas to separate statements |
| |
On 2020-09-29 09:00, Christophe JAILLET wrote: > Le 29/09/2020 à 15:14, Julia Lawall a écrit : >> Replace commas with semicolons. Commas introduce unnecessary >> variability in the code structure and are hard to see. What is done >> is essentially described by the following Coccinelle semantic patch >> (http://coccinelle.lip6.fr/): >> >> // <smpl> >> @@ expression e1,e2; @@ >> e1 >> -, >> +; >> e2 >> ... when any >> // </smpl> >> >> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> >> >> --- >> drivers/media/usb/dvb-usb-v2/lmedm04.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c >> b/drivers/media/usb/dvb-usb-v2/lmedm04.c >> index 5a7a9522d46d..9ddda8d68ee0 100644 >> --- a/drivers/media/usb/dvb-usb-v2/lmedm04.c >> +++ b/drivers/media/usb/dvb-usb-v2/lmedm04.c >> @@ -391,7 +391,7 @@ static int lme2510_int_read(struct dvb_usb_adapter >> *adap) >> ep = usb_pipe_endpoint(d->udev, lme_int->lme_urb->pipe); >> if (usb_endpoint_type(&ep->desc) == USB_ENDPOINT_XFER_BULK) >> - lme_int->lme_urb->pipe = usb_rcvbulkpipe(d->udev, 0xa), >> + lme_int->lme_urb->pipe = usb_rcvbulkpipe(d->udev, 0xa); >> usb_submit_urb(lme_int->lme_urb, GFP_ATOMIC); >> info("INT Interrupt Service Started"); >> >> > Ouch! > > This one looks like a real issue!
Julia? Did you do this one by hand? This actually changes logic which I did not expectthe cocci script to do. > CJ
| |