lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] dt-bindings: interconnect: Add bindings for Qualcomm SDM660 NoC
On Mon, Sep 28, 2020 at 09:58:53PM +0200, kholk11@gmail.com wrote:
> From: AngeloGioacchino Del Regno <kholk11@gmail.com>
>
> Add the bindings for the Qualcomm SDM660-class NoC, valid for
> SDM630, SDM636, SDM660 and SDA variants.
>
> Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
> ---
> .../bindings/interconnect/qcom,sdm660.yaml | 147 ++++++++++++++++++
> 1 file changed, 147 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml
> new file mode 100644
> index 000000000000..440e9bc1382a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml
> @@ -0,0 +1,147 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,sdm660.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SDM660 Network-On-Chip interconnect
> +
> +maintainers:
> + - Georgi Djakov <georgi.djakov@linaro.org>
> +
> +description: |
> + The Qualcomm SDM660 interconnect providers support adjusting the
> + bandwidth requirements between the various NoC fabrics.
> +
> +properties:
> + reg:
> + maxItems: 1
> +
> + compatible:
> + enum:
> + - qcom,sdm660-a2noc
> + - qcom,sdm660-bimc
> + - qcom,sdm660-cnoc
> + - qcom,sdm660-gnoc
> + - qcom,sdm660-mnoc
> + - qcom,sdm660-snoc
> +
> + '#interconnect-cells':
> + const: 1
> +
> + clocks:
> + minItems: 1

Looks like 2 is the min?

> + maxItems: 3
> +
> + clock-names:
> + minItems: 1
> + maxItems: 3
> +
> +required:
> + - compatible
> + - reg
> + - '#interconnect-cells'
> + - clock-names
> + - clocks
> +
> +additionalProperties: false
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sdm660-mnoc
> + then:
> + properties:
> + clocks:
> + items:
> + - description: Bus Clock.
> + - description: Bus A Clock.
> + - description: CPU-NoC High-performance Bus Clock.
> + clock-names:
> + items:
> + - const: bus
> + - const: bus_a
> + - const: iface

Given both cases are the same except the 3rd clock, all this can be
moved to the main section. Then here you just need to restrict things
to 2 or 3 clocks.

> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sdm660-a2noc
> + - qcom,sdm660-bimc
> + - qcom,sdm660-cnoc
> + - qcom,sdm660-gnoc
> + - qcom,sdm660-snoc
> + then:
> + properties:
> + clocks:
> + items:
> + - description: Bus Clock.
> + - description: Bus A Clock.
> + clock-names:
> + items:
> + - const: bus
> + - const: bus_a
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,rpmcc.h>
> + #include <dt-bindings/clock/qcom,mmcc-sdm660.h>
> +
> + bimc: interconnect@1008000 {
> + compatible = "qcom,sdm660-bimc";
> + reg = <0x01008000 0x78000>;
> + #interconnect-cells = <1>;
> + clock-names = "bus", "bus_a";
> + clocks = <&rpmcc RPM_SMD_BIMC_CLK>,
> + <&rpmcc RPM_SMD_BIMC_A_CLK>;
> + };
> +
> + cnoc: interconnect@1500000 {
> + compatible = "qcom,sdm660-cnoc";
> + reg = <0x01500000 0x10000>;
> + #interconnect-cells = <1>;
> + clock-names = "bus", "bus_a";
> + clocks = <&rpmcc RPM_SMD_CNOC_CLK>,
> + <&rpmcc RPM_SMD_CNOC_A_CLK>;
> + };
> +
> + snoc: interconnect@1626000 {
> + compatible = "qcom,sdm660-snoc";
> + reg = <0x01626000 0x7090>;
> + #interconnect-cells = <1>;
> + clock-names = "bus", "bus_a";
> + clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
> + <&rpmcc RPM_SMD_SNOC_A_CLK>;
> + };
> +
> + a2noc: interconnect@1704000 {
> + compatible = "qcom,sdm660-a2noc";
> + reg = <0x01704000 0xc100>;
> + #interconnect-cells = <1>;
> + clock-names = "bus", "bus_a";
> + clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>,
> + <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>;
> + };
> +
> + mnoc: interconnect@1745000 {
> + compatible = "qcom,sdm660-mnoc";
> + reg = <0x01745000 0xa010>;
> + #interconnect-cells = <1>;
> + clock-names = "bus", "bus_a", "iface";
> + clocks = <&rpmcc RPM_SMD_MMSSNOC_AXI_CLK>,
> + <&rpmcc RPM_SMD_MMSSNOC_AXI_CLK_A>,
> + <&mmcc AHB_CLK_SRC>;
> + };
> +
> + gnoc: interconnect@17900000 {
> + compatible = "qcom,sdm660-gnoc";
> + reg = <0x17900000 0xe000>;
> + #interconnect-cells = <1>;
> + clock-names = "bus", "bus_a";
> + clocks = <&xo_board>, <&xo_board>;
> + };
> --
> 2.28.0
>

\
 
 \ /
  Last update: 2020-09-29 16:48    [W:0.122 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site