lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] pinctrl: bcm: fix kconfig dependency warning when !GPIOLIB
On Mon, Sep 14, 2020 at 4:41 PM Necip Fazil Yildiran
<fazilyildiran@gmail.com> wrote:

> When PINCTRL_BCM2835 is enabled and GPIOLIB is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
> Depends on [n]: GPIOLIB [=n]
> Selected by [y]:
> - PINCTRL_BCM2835 [=y] && PINCTRL [=y] && OF [=y] && (ARCH_BCM2835 [=n] || ARCH_BRCMSTB [=n] || COMPILE_TEST [=y])
>
> The reason is that PINCTRL_BCM2835 selects GPIOLIB_IRQCHIP without
> depending on or selecting GPIOLIB while GPIOLIB_IRQCHIP is subordinate to
> GPIOLIB.
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: 85ae9e512f43 ("pinctrl: bcm2835: switch to GPIOLIB_IRQCHIP")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>

Patch applied to non-critical fixes, thanks!

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2020-09-29 15:00    [W:0.048 / U:1.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site