lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] platform_data: ti: fix a typo
From
Date
Hi Wang Qing,

Thank you for your patch.

On 26/9/20 4:49, Wang Qing wrote:
> Modify the typo: "compliment" -> "complement".
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> include/linux/platform_data/cros_ec_commands.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
> index 1fcfe9e..42203ce
> --- a/include/linux/platform_data/cros_ec_commands.h
> +++ b/include/linux/platform_data/cros_ec_commands.h
> @@ -261,12 +261,12 @@
> /* Memory space version; set to EC_ACPI_MEM_VERSION_CURRENT */
> #define EC_ACPI_MEM_VERSION 0x00
> /*
> - * Test location; writing value here updates test compliment byte to (0xff -
> + * Test location; writing value here updates test complement byte to (0xff -
> * value).
> */
> #define EC_ACPI_MEM_TEST 0x01
> -/* Test compliment; writes here are ignored. */
> -#define EC_ACPI_MEM_TEST_COMPLIMENT 0x02
> +/* Test complement; writes here are ignored. */
> +#define EC_ACPI_MEM_TEST_COMPLEMENT 0x02
>

Although there is a typo, we did an effort to have cros_ec_command synced with
ec commands in the firmware code, so I'd like to see this change also applied on
the EC code. Do you mind to populate this change in the EC firmware code [1], please

[1] https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/master

Thanks,
Enric


> /* Keyboard backlight brightness percent (0 - 100) */
> #define EC_ACPI_MEM_KEYBOARD_BACKLIGHT 0x03
>

\
 
 \ /
  Last update: 2020-09-29 09:55    [W:0.034 / U:1.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site