lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1 vhost-next] vdpa/mlx5: Make vdpa core driver a distinct module
On Tue, Sep 29, 2020 at 03:17:05AM -0400, Michael S. Tsirkin wrote:
> >
> > Use "select MLX5_CORE"
> > instead of "depends on MLX5_CORE"
> >
> > Wasn't this agreed upon?
>
> Hmm I don't know. I recall a similar discussion around VHOST_IOTLB.
> That's different ...

I see.

>
> I see
>
> [linux]$ git grep MLX5_CORE|grep depends
> drivers/infiniband/hw/mlx5/Kconfig: depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on NETDEVICES && ETHERNET && INET && PCI && MLX5_CORE
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN && RFS_ACCEL
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN && NET_SWITCHDEV
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN && DCB
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on TLS=y || MLX5_CORE=m
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on TLS=y || MLX5_CORE=m
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN && MLX5_ESWITCH
> drivers/vdpa/Kconfig: depends on MLX5_CORE
>
> and no selects of this symbol, I guess you are saying you are changing everything
> else to select - is that right? Then I guess vdpa should follow suit ...
>

No, I will leave that and will discuss internally if/who/when will do
this.

\
 
 \ /
  Last update: 2020-09-29 09:44    [W:0.079 / U:26.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site