lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 187/245] mtd: rawnand: omap_elm: Fix runtime PM imbalance on error
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit 37f7212148cf1d796135cdf8d0c7fee13067674b ]

    pm_runtime_get_sync() increments the runtime PM usage counter even
    when it returns an error code. Thus a pairing decrement is needed on
    the error handling path to keep the counter balanced.

    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/20200522104008.28340-1-dinghao.liu@zju.edu.cn
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/nand/raw/omap_elm.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/mtd/nand/raw/omap_elm.c b/drivers/mtd/nand/raw/omap_elm.c
    index a3f32f939cc17..6736777a41567 100644
    --- a/drivers/mtd/nand/raw/omap_elm.c
    +++ b/drivers/mtd/nand/raw/omap_elm.c
    @@ -421,6 +421,7 @@ static int elm_probe(struct platform_device *pdev)
    pm_runtime_enable(&pdev->dev);
    if (pm_runtime_get_sync(&pdev->dev) < 0) {
    ret = -EINVAL;
    + pm_runtime_put_sync(&pdev->dev);
    pm_runtime_disable(&pdev->dev);
    dev_err(&pdev->dev, "can't enable clock\n");
    return ret;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-29 14:25    [W:7.280 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site