lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 4/4] scsi: ufs-mediatek: Add host reset mechanism
Date
> 
>
> Add host reset mechanism to try to recover host-side errors
> during recovery flow.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by Avri Altman <avri.altman@wdc.com>

See some nit below as well.
Thanks,
Avri

> +static void ufs_mtk_init_reset_control(struct ufs_hba *hba,
> + struct reset_control **rc,
> + char *str)
> +{
> + *rc = devm_reset_control_get(hba->dev, str);
> + if (IS_ERR(*rc)) {
How about verifying that the line is not shared as well?
Although this might not be an issue on your current platforms,
it might save you aggravation in the future..

> + dev_info(hba->dev, "Failed to get reset control %s: %d\n",
> + str, PTR_ERR(*rc));
> + *rc = NULL;
> + }
> +}

\
 
 \ /
  Last update: 2020-09-29 13:56    [W:1.625 / U:5.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site