Messages in this thread |  | | Date | Mon, 28 Sep 2020 09:28:39 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH] hwmon: add support for SMSC EMC2305/03/02/01 fan controller |
| |
On Mon, Sep 28, 2020 at 06:43:26PM +0800, Biwen Li wrote: > From: Reinhard Pfau <pfau@gdsys.de> > > Add support for SMSC EMC2305, EMC2303, EMC2302, EMC2301 fan controller > chips. > The driver primary supports the EMC2305 chip which provides RPM-based > PWM control and monitoring for up to 5 fans. > > According to the SMSC data sheets the EMC2303, EMC2302 and EMC2301 chips > have basically the same functionality and register layout, but support > less fans and (in case of EMC2302 and EMC2301) less possible I2C addresses. > The driver supports them, too. > > The driver supports configuration via devicetree. This can also be used > to restrict the fans exposed via sysfs (see doc for details). > > Signed-off-by: Reinhard Pfau <pfau@gdsys.de> > Signed-off-by: Biwen Li <biwen.li@nxp.com> > --- ...
> + > + hwmon_dev = devm_hwmon_device_register_with_groups(&client->dev, > + client->name, data, > + data->groups);
New drivers must use "[devm_]hwmon_device_register_with_info" to register with the hwmon subsystem.
Guenter
|  |