Messages in this thread | | | Subject | Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call | From | Sinan Kaya <> | Date | Mon, 28 Sep 2020 08:11:37 -0400 |
| |
On 9/27/2020 10:43 PM, Kuppuswamy, Sathyanarayanan wrote: >> 2. no bus reset on NON_FATAL error through AER driver path. >> This already tells me that you need to split your change into >> multiple patches. >> >> Let's talk about this too. bus reset should be triggered via >> AER driver before informing the recovery. > But as per error recovery documentation, any call to > ->error_detected() or ->mmio_enabled() can request > PCI_ERS_RESULT_NEED_RESET. So we need to add code > to do the actual reset before calling ->slot_reset() > callback. So call to pci_reset_bus() fixes this > issue. > > if (status == PCI_ERS_RESULT_NEED_RESET) { > + pci_reset_bus(dev);
This part seems to make sense as you already highlighted there is a TO-DO in the code.
This is an independent change that deserves its own patch.
| |