lkml.org 
[lkml]   [2020]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH RFC v7 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings
Hi maxime,
Sorry, I forgot to describe ports subnode with my two port@X, i will be fix it.

Thanks for reminding

Maxime Ripard <maxime@cerno.tech> 于2020年9月28日周一 下午4:20写道:
>
> Hi!
>
> On Mon, Sep 28, 2020 at 02:27:39PM +0800, Kevin Tang wrote:
> > From: Kevin Tang <kevin.tang@unisoc.com>
> >
> > Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY)
> > support for Unisoc's display subsystem.
> >
> > RFC v7:
> > - Fix DTC unit name warnings
> > - Fix the problem of maintainers
> >
> > Cc: Orson Zhai <orsonzhai@gmail.com>
> > Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> > Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> > ---
> > .../display/sprd/sprd,sharkl3-dsi-host.yaml | 98 ++++++++++++++++++++++
> > .../display/sprd/sprd,sharkl3-dsi-phy.yaml | 75 +++++++++++++++++
> > 2 files changed, 173 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml
> > create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml
> > new file mode 100644
> > index 0000000..b6bbf67
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml
> > @@ -0,0 +1,98 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-host.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Unisoc MIPI DSI Controller
> > +
> > +maintainers:
> > + - Kevin Tang <kevin.tang@unisoc.com>
> > +
> > +properties:
> > + compatible:
> > + const: sprd,sharkl3-dsi-host
> > +
> > + reg:
> > + maxItems: 1
> > + description:
> > + Physical base address and length of the registers set for the device.
> > +
> > + interrupts:
> > + maxItems: 2
> > + description:
> > + Should contain DSI interrupt.
> > +
> > + clocks:
> > + minItems: 1
> > +
> > + clock-names:
> > + items:
> > + - const: clk_src_96m
> > +
> > + power-domains:
> > + maxItems: 1
> > + description: A phandle to DSIM power domain node
> > +
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > + port@0:
> > + type: object
> > + description:
> > + A port node with endpoint definitions as defined in
> > + Documentation/devicetree/bindings/media/video-interfaces.txt.
> > + That port should be the input endpoint, usually coming from
> > + the associated DPU.
> > + port@1:
> > + type: object
> > + description:
> > + A port node with endpoint definitions as defined in
> > + Documentation/devicetree/bindings/media/video-interfaces.txt.
> > + That port should be the output endpoint, usually output to
> > + the associated DPHY.
>
> Is there a specific reason you don't follow the OF-graph and have a
> ports subnode with your two port@X in there?
>
> Maxime

\
 
 \ /
  Last update: 2020-09-28 13:30    [W:0.048 / U:11.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site