Messages in this thread | | | Date | Mon, 28 Sep 2020 19:14:39 -0700 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH v4 1/2] dt-bindings: usb: Add binding for discrete onboard USB hubs |
| |
On Mon, Sep 28, 2020 at 03:13:26PM -0700, Doug Anderson wrote: > Hi, > > On Mon, Sep 28, 2020 at 10:14 AM Matthias Kaehlcke <mka@chromium.org> wrote: > > > > +examples: > > + - | > > + usb_hub: usb-hub { > > + compatible = "realtek,rts5411", "onboard-usb-hub"; > > + vdd-supply = <&pp3300_hub>;
I will admit that using the name 'vdd' for a sole supply is somewhat arbitrary, if anybody has better suggestions I'm open to it :)
> > + }; > > + > > + usb_controller { > > Super nitty nit: prefer dashes for node names.
ack
> > + dr_mode = "host"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + /* 2.0 hub on port 1 */ > > + hub@1 { > > + compatible = "usbbda,5411"; > > Presumably we need something in the bindings for "usbbda,5411" ?
I'm not sure how this should look like in a .yaml. Rob, do you have any suggestions?
Strictly speaking the compatible string isn't needed, the driver will match the device without it based on VID/PID and the port.
> > + reg = <1>; > > + hub = <&usb_hub>; > > + }; > > + > > + /* 3.0 hub on port 2 */ > > + hub@2 { > > + compatible = "usbbda,411"; > > Presumably we need something in the bindings for "usbbda,411" ?
ditto
| |