lkml.org 
[lkml]   [2020]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v17 06/12] soc: mediatek: Add support for hierarchical scpsys device node
On Thu, Aug 6, 2020 at 5:22 PM Weiyi Lu <weiyi.lu@mediatek.com> wrote:
>
> Try to list all the power domains of under power controller
> node to show the dependency between each power domain directly
> instead of filling the dependency in scp_soc_data.
> And could be more clearly to group subsys clocks into power domain
> sub node to introduce subsys clocks of bus protection in next patch.
>
> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
> ---
[snip]
> +static int traverse_scp(struct platform_device *pdev, struct scp *scp,
> + const struct scp_domain_data *scp_domain_data)
> +{
> + struct device *dev = &pdev->dev;
> + struct device_node *np = dev->of_node;
> + struct device_node *sub;
> + int ret;
> +
> + INIT_LIST_HEAD(&scp->dep_links);
> +
> + for_each_available_child_of_node(np, sub) {
> + ret = scpsys_get_domain(pdev, scp, sub, scp_domain_data);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to handle node %pOFn: %d\n", sub, ret);

minor comment: this error should not be printed if ret ==
-EPROBE_DEFER (use the new dev_err_probe?)

> + goto err;
> + }
> + }
> +
> + return 0;
> +
> +err:
> + of_node_put(sub);
> + return ret;
> +}
[snip]

\
 
 \ /
  Last update: 2020-09-28 09:15    [W:0.086 / U:12.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site