lkml.org 
[lkml]   [2020]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 1/2] dt-bindings: usb: Add binding for discrete onboard USB hubs
Hi,

On Mon, Sep 28, 2020 at 10:14 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> +examples:
> + - |
> + usb_hub: usb-hub {
> + compatible = "realtek,rts5411", "onboard-usb-hub";
> + vdd-supply = <&pp3300_hub>;
> + };
> +
> + usb_controller {

Super nitty nit: prefer dashes for node names.


> + dr_mode = "host";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* 2.0 hub on port 1 */
> + hub@1 {
> + compatible = "usbbda,5411";

Presumably we need something in the bindings for "usbbda,5411" ?


> + reg = <1>;
> + hub = <&usb_hub>;
> + };
> +
> + /* 3.0 hub on port 2 */
> + hub@2 {
> + compatible = "usbbda,411";

Presumably we need something in the bindings for "usbbda,411" ?


-Doug

\
 
 \ /
  Last update: 2020-09-29 01:44    [W:0.095 / U:1.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site