lkml.org 
[lkml]   [2020]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4.19 38/92] kprobes: Fix NULL pointer dereference at kprobe_ftrace_handler
    On Mon, 28 Sep 2020 18:09:42 -0400
    Steven Rostedt <rostedt@goodmis.org> wrote:

    > On Tue, 29 Sep 2020 01:32:59 +0530
    > Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
    >
    > > stable rc branch 4.19 build warning on arm64.
    > >
    > > ../kernel/kprobes.c: In function ‘kill_kprobe’:
    > > ../kernel/kprobes.c:1070:33: warning: statement with no effect [-Wunused-value]
    > > 1070 | #define disarm_kprobe_ftrace(p) (-ENODEV)
    > > | ^
    > > ../kernel/kprobes.c:2090:3: note: in expansion of macro ‘disarm_kprobe_ftrace’
    > > 2090 | disarm_kprobe_ftrace(p);
    > > | ^~~~~~~~~~~~~~~~~~~~
    >
    > Seems to affect upstream as well.
    >

    Bah, no (tested the wrong kernel).

    You want this commit too:

    10de795a5addd ("kprobes: Fix compiler warning for !CONFIG_KPROBES_ON_FTRACE")

    -- Steve

    \
     
     \ /
      Last update: 2020-09-29 01:36    [W:4.136 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site