lkml.org 
[lkml]   [2020]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4] mtd: parsers: bcm63xx: simplify CFE detection
From
Date


On 9/28/2020 7:16 AM, Miquel Raynal wrote:
> Hello,
>
> Guenter Roeck <linux@roeck-us.net> wrote on Mon, 21 Sep 2020 20:26:19
> -0700:
>
>> On 9/21/20 8:18 PM, Naresh Kamboju wrote:
>>> On Fri, 14 Aug 2020 at 14:26, Guenter Roeck <linux@roeck-us.net> wrote:
>>>>
>>>> On Mon, Jun 15, 2020 at 11:17:40AM +0200, Álvaro Fernández Rojas wrote:
>>>>> Instead of trying to parse CFE version string, which is customized by some
>>>>> vendors, let's just check that "CFE1" was passed on argument 3.
>>>>>
>>>>> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
>>>>> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
>>>>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>>>>
>>>
>>> We still see mips: allmodconfig build failure on Linus tree
>>>
>>
>> Yes, same here.
>
> Perhaps this check should be done by an exported helper so that we do
> not blindly export the variable?
>
> Alvaro, Jonas, can one of you try to address this issue please?

We should probably just make the parser 'bool' there is no much point
building this as a module, it will not improve compile time coverage,
and it will most likely not help with the kernel image size on the
platforms that require the parser to be there anyway.
--
Florian

\
 
 \ /
  Last update: 2020-09-28 21:35    [W:0.118 / U:31.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site