lkml.org 
[lkml]   [2020]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ARM: davinci: fix kconfig dependency warning when !GPIOLIB
From
Date
On 14/09/20 7:49 PM, Necip Fazil Yildiran wrote:
> When MACH_DAVINCI_DA830_EVM is enabled and GPIOLIB is disabled, it results
> in the following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for GPIO_PCF857X
> Depends on [n]: GPIOLIB [=n] && I2C [=y]
> Selected by [y]:
> - MACH_DAVINCI_DA830_EVM [=y] && ARCH_DAVINCI [=y] && ARCH_DAVINCI_DA830 [=y] && I2C [=y]
>
> The reason is that MACH_DAVINCI_DA830_EVM selects GPIO_PCF857X without
> depending on or selecting GPIOLIB while GPIO_PCF857X is subordinate to
> GPIOLIB.
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: 77316f057526 ("davinci: DA830/OMAP-L137 EVM: use runtime detection for UI card")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>

Here too, I think changing to "imply GPIO_PCF857X if I2C" is better.

Thanks,
Sekhar

\
 
 \ /
  Last update: 2020-09-28 20:13    [W:0.034 / U:1.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site