Messages in this thread | | | Subject | Re: [PATCH 4/5 V2] PCI: only return true when dev io state is really changed | From | Joe Perches <> | Date | Sat, 26 Sep 2020 21:16:32 -0700 |
| |
On Sat, 2020-09-26 at 23:28 -0400, Ethan Zhao wrote: > simplify the pci_dev_set_io_state() function to only return true > when dev->error_state is changed. [] > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h [] > @@ -362,35 +362,11 @@ static inline bool pci_dev_set_io_state(struct pci_dev *dev, > bool changed = false; [] > + if (dev->error_state == new) > + return changed; > + > + dev->error_state = new; > + changed = true; > return changed; > }
This would be simpler removing the unnecessary changed automatic
...
if (dev->error_state == new) return false;
dev->error_state = new;
return true; }
| |