Messages in this thread | | | Date | Sat, 26 Sep 2020 08:50:15 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/5] misc: vop: change the way of allocating vring for noncoherent platform |
| |
> +#include <linux/dma-noncoherent.h>
This header must not be included in drivers.
> > + if (dev_is_dma_coherent(vop_dev(vdev)))
And this API must not be used in drivers either.
> + vdev->vvr[i].vrh.vring.used = > + (void __force *)vpdev->hw_ops->remap(
And you must not use __force casts without a comment explanation why they are safe.
| |