Messages in this thread | | | Subject | Re: [PATCH 5/5] iommu/tegra-smmu: Add pagetable mappings to debugfs | From | Dmitry Osipenko <> | Date | Sun, 27 Sep 2020 00:37:56 +0300 |
| |
27.09.2020 00:24, Dmitry Osipenko пишет: > 26.09.2020 11:07, Nicolin Chen пишет: > ... >> + for (pd_index = 0; pd_index < SMMU_NUM_PDE; pd_index++) { >> + struct page *pt; >> + u32 *addr; >> + >> + if (!as->count[pd_index] || !pd[pd_index]) >> + continue; > > I guess the idea of this patch is to print out the hardware state, isn't > it? Hence the as->count shouldn't be checked here.
Perhaps also will be good to check whether the state of !as->count[pd_index] matches state of !pd[pd_index].
WARN_ON_ONCE(!as->count[pd_index] ^ !pd[pd_index])
| |