lkml.org 
[lkml]   [2020]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4] powercap: include header to fix -Wmissing-prototypes
On Tue, Sep 22, 2020 at 6:47 AM Pujin Shi <shipujin.t@gmail.com> wrote:
>
> Include the linux/idle_inject.h header to fix W=1 build warning:
>
> drivers/powercap/idle_inject.c:152:6: warning: no previous prototype for ‘idle_inject_set_duration’ [-Wmissing-prototypes]
> drivers/powercap/idle_inject.c:167:6: warning: no previous prototype for ‘idle_inject_get_duration’ [-Wmissing-prototypes]
> drivers/powercap/idle_inject.c:179:6: warning: no previous prototype for ‘idle_inject_set_latency’ [-Wmissing-prototypes]
> drivers/powercap/idle_inject.c:195:5: warning: no previous prototype for ‘idle_inject_start’ [-Wmissing-prototypes]
> drivers/powercap/idle_inject.c:227:6: warning: no previous prototype for ‘idle_inject_stop’ [-Wmissing-prototypes]
> drivers/powercap/idle_inject.c:299:28: warning: no previous prototype for ‘idle_inject_register’ [-Wmissing-prototypes]
> drivers/powercap/idle_inject.c:345:6: warning: no previous prototype for ‘idle_inject_unregister’ [-Wmissing-prototypes]
>
> Signed-off-by: Pujin Shi <shipj@lemote.com>
> ---
> drivers/powercap/idle_inject.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/powercap/idle_inject.c b/drivers/powercap/idle_inject.c
> index 4310901a074e..6e1a0043c411 100644
> --- a/drivers/powercap/idle_inject.c
> +++ b/drivers/powercap/idle_inject.c
> @@ -43,6 +43,7 @@
> #include <linux/sched.h>
> #include <linux/slab.h>
> #include <linux/smpboot.h>
> +#include <linux/idle_inject.h>
>
> #include <uapi/linux/sched/types.h>
>
> --

Note that the contact information in the S-o-b tag should match the
From: header exactly.

I've fixed that up manually this time and applied the patch (as 5.10
material), but please be more careful about it in the future.

Thanks!

\
 
 \ /
  Last update: 2020-09-25 16:50    [W:0.039 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site