Messages in this thread | | | Date | Fri, 25 Sep 2020 15:26:36 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups |
| |
On Thu, Sep 24, 2020 at 09:44:53PM +0900, Namhyung Kim wrote:
SNIP
> > + if (metric_events) { > + orig_metric_events = *metric_events; > + rblist__init(metric_events); > + } else { > + rblist__init(&orig_metric_events); > + } > + > for (;;) { > p = strchr(str, ','); > e = p ? p : eos; > @@ -255,6 +267,14 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str) > cgroup__put(cgrp); > nr_cgroups++; > > + if (metric_events) { > + perf_stat__collect_metric_expr(tmp_list); > + if (metricgroup__copy_metric_events(tmp_list, cgrp, > + metric_events, > + &orig_metric_events) < 0) > + break; > + }
looks good, do you plan to actualy add support for record? my ack from last version stays
thanks, jirka
| |