Messages in this thread | | | Subject | Re: [PATCH] mtd: spi-nor: controllers: intel-spi: Add support for command line partitions | From | Vignesh Raghavendra <> | Date | Fri, 25 Sep 2020 09:51:14 +0530 |
| |
On 4/17/20 9:37 PM, Mika Westerberg wrote: > On Fri, Apr 17, 2020 at 08:26:11AM -0700, Ronald G. Minnich wrote: >> On Intel platforms, the usable SPI area is located several >> MiB in from the start, to leave room for descriptors and >> the Management Engine binary. Further, not all the remaining >> space can be used, as the last 16 MiB contains firmware. >> >> To make the SPI usable for mtdblock and other devices, >> it is necessary to enable command line partitions so the >> middle usable region can be specified. >> >> Add a part_probes array which includes only "cmdelineparts", >> and change to mtd_device_parse_register to use this part_probes. >> >> Signed-off-by: Ronald G. Minnich <rminnich@google.com> > > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> >
scripts/checkpatch.pl --strict complains:
CHECK: Alignment should match open parenthesis #46: FILE: drivers/mtd/spi-nor/controllers/intel-spi.c:956: + ret = mtd_device_parse_register(&ispi->nor.mtd, part_probes, + NULL, &part, 1);
WARNING: Missing Signed-off-by: line by nominal patch author '"Ronald G. Minnich" <rminnich@gmail.com>'
Regards Vignesh
| |