lkml.org 
[lkml]   [2020]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] slimbus: core: check get_addr before removing laddr ida
From
Date


On 25/09/2020 13:41, Greg KH wrote:
> On Fri, Sep 25, 2020 at 10:55:18AM +0100, Srinivas Kandagatla wrote:
>> logical address can be either assigned by the SLIMBus controller or the core.
>> Core uses IDA in cases where get_addr callback is not provided by the
>> controller.
>> Core already has this check while allocating IDR, however during absence
>> reporting this is not checked. This patch fixes this issue.
>>
>> Fixes: 46a2bb5a7f7ea("slimbus: core: Add slim controllers support")
>
> Nit, you need a ' ' before the '(' character...
>
Not sure how I missed that :-)

> Also, you don't need all of those characters, you have 1 more than
> necessary :)
>
> I'll go fix it up.
Thankyou very much for fixing this up!

--srini
>
> greg k-h
>

\
 
 \ /
  Last update: 2020-09-25 14:42    [W:0.164 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site